Fix f16/f128 TypeKind UB causing SIGTRAP on aarch64#374
Merged
LegNeato merged 1 commit intoRust-GPU:mainfrom Apr 4, 2026
Merged
Fix f16/f128 TypeKind UB causing SIGTRAP on aarch64#374LegNeato merged 1 commit intoRust-GPU:mainfrom
LegNeato merged 1 commit intoRust-GPU:mainfrom
Conversation
The `TypeKind` repr(C) enum was missing `X86_FP80`, `FP128`, and `PPC_FP128` variants (values 4, 5, 6). When `compiler_builtins` is compiled with `--cfg f128_enabled` (new in recent nightlies), the C FFI function `LLVMRustGetTypeKind` returns 5 for fp128 types. The Rust enum had no variant for that discriminant, causing instant undefined behavior (manifesting as SIGTRAP). Also adds f16 and f128 cases to the ABI `Reg::llvm_type` float match, which previously only handled 32 and 64-bit floats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TypeKindrepr(C) enum was missingX86_FP80,FP128, andPPC_FP128variants. Whencompiler_builtinsis compiled with--cfg f128_enabled(new in recent nightlies), the C FFI functionLLVMRustGetTypeKindreturns 5 for fp128 types. The Rust enum had no variant for that discriminant, causing instant undefined behavior. I saw this manifesting as SIGTRAP.Also adds f16 and f128 cases to the ABI
Reg::llvm_typefloat match, which previously only handled 32 and 64-bit floats.